I didn't had the chance yet to compile/test it (not sufficient hardware at this time), I was more asking for the kind a review you gave before to try to compile/test it.

About your comment on line 196 (which probably also applies to lines 238 and 274), what is proper way to receive a set from python ?

Best,
François



2015-04-15 0:00 GMT+02:00 Tiago de Paula Peixoto <tiago@skewed.de>:
On 15.04.2015 00:27, François wrote:
> I forked the grap_tool github repo, and tried to update the grpah_distance.cc.
>
> The result is visible there
> <https://github.com/Fkawala/graph-tool/blob/master/src/graph/topology/graph_distance.cc>. However,
> I'm not familiar with CPP, thus the result might be disappointing.
>
> Would it worth it that I try to go further on this ?

Your idea is correct, but a couple of things look strange. E.g. in line 111

     std::size_t search = _target.find(v);

I'm pretty sure the iterator type of unordered_set<> is not an
integer. Also, in the function definition in line 196 you use
"std::unordered_set tgt", but you cannot receive this type of object
from Python, since it has not yet been exposed.

Did you even try to compile and use it?

(If you want, you can just wait a bit for me to implement this myself in
the next couple of days, since it is not very difficult.)

Best,
Tiago

--
Tiago de Paula Peixoto <tiago@skewed.de>


_______________________________________________
graph-tool mailing list
graph-tool@skewed.de
http://lists.skewed.de/mailman/listinfo/graph-tool




--
François Kawala